Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear code #5

Open
5 tasks
Sanduhr32 opened this issue Jul 18, 2020 · 2 comments
Open
5 tasks

Unclear code #5

Sanduhr32 opened this issue Jul 18, 2020 · 2 comments
Assignees

Comments

@Sanduhr32
Copy link

Sanduhr32 commented Jul 18, 2020

  • StringUtils#capitalizeFully(String string) only capitalizes the first letter of each word. With fully in it's name, i'ld assume that it capitalizes the whole string.
  • Also missing docs.
  • EmbedUtils#setDefaultColor(Color / int) & overloading EmbedUtils#getColorOrDefault(long guildId) that falls back to the set color for avoiding repeated arguments. Also could use a Supplier/Function to get a color
  • Renaming variables like long key to long guildId for having more descriptive parameter names.
  • MessageUtils#sendMsg() (yes the main one where everything gets piped through) The MessageBuilder contains dunctebot in its nonce, which seems inappropriate for other bots.
@Sanduhr32 Sanduhr32 changed the title Misleading method name Unclear code Jul 18, 2020
@duncte123 duncte123 self-assigned this Jul 20, 2020
@duncte123
Copy link
Owner

StringUtils#capitalizeFully(String string) only capitalizes the first letter of each word. With fully in it's name, i'ld assume that it capitalizes the whole string.

"Capitalization (North American English) or capitalisation (British English) is writing a word with its first letter as a capital letter (uppercase letter) and the remaining letters in lower case, in writing systems with a case distinction. The term also may refer to the choice of the casing applied to text."

@Sanduhr32
Copy link
Author

Fully is an adjective describing a term more accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants