Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trades from DEX Swapr to Ethereum dex.trades #622

Closed
wants to merge 1 commit into from

Conversation

arekgotfryd
Copy link

I added swaps from DEX Swapr to Ethereum dex.trades on Dune Analytics
Issue #601

I've checked that:

  • the query produces the intended results
  • the folder name matches the schema name
  • the schema name exists in Dune
  • views are prefixed with view_, functions with fn_.
  • the filename matches the defined view, table or function and ends with .sql
  • each file has only one view, table or function defined
  • column names are lowercase_snake_cased

I added swaps from DEX Swapr to Ethereum dex.trades on Dune Analytics
Issue duneanalytics#601
@masquot
Copy link
Contributor

masquot commented Dec 15, 2021

Thank you for your contribution @arekgotfryd!

I executed your query for the year 2021 and loaded the results in a test table:
https://dune.xyz/queries/297234

Comparing these results to the Swapr stats https://dxstats.eth.link/#/home - it seems like there are swaps missing?

@masquot masquot self-assigned this Dec 15, 2021
@arekgotfryd
Copy link
Author

Thanks for your response @masquot!
I just ran following script
https://dune.xyz/queries/297370
which contains union of all tables with swap in the name for swapr namespace
in Dune Analytics app and it looks like results are pretty consistent with what I got in my query.
Where should I look for additional swaps in your opinion?

@masquot
Copy link
Contributor

masquot commented Dec 16, 2021

Thank you @arekgotfryd.

Haven't looked in detail, but it's possible that not all Swapr contracts are decoded yet and hence not available in Dune. You can find more info about the decoding process and how to submit contracts here: https://docs.dune.xyz/data-tables/data-tables/decoded-data

For getting this PR approved, we need to get the data from Swapr stats https://dxstats.eth.link/#/home reconciled with the results of running your code. For missing transactions, you will need to figure out the exchange contract address using Etherscan and possible add it do Dune. In most cases, we recommend using event data instead of function call data if available.

Are you on Dune's discord yet? That is the best place if you have further questions: https://discord.com/invite/ErrzwBz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants