-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1inch to dex.trades on polygon #625
Conversation
@k06a. Maybe you or someone of the team would like to review this one? |
|
would it be possible to have an example of a swap that has two rows @nata-omutyanka ? |
For example \x00cecbd9332c235b07f8088b18072c6dbb0d4ed19faf3d4b0756cb63e2e90a6c |
To keep you updated I've requested in another PR #648 . It will resolve the missing swaps that don't have the names of tokens. And I changed a bit the trade_id so that you can only query all rows where trade_id = 1 to don't get any duplicates. I've updated the dune_user_generated.oneinch and will once again the new token prices will be merged @nata-omutyanka |
ok just to keep you updated @nata-omutyanka the PR has been merged so now it should be good :) |
What's the state of this PR? |
I think everything is good |
Added 1inch to dex.trades table on Polygon as requested in #606.
Results of the 1inch query can be checked at the dune_user_generated.oneinch table.
I've checked that:
view_
, functions withfn_
.lowercase_snake_cased