Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1inch to dex.trades on polygon #625

Merged
merged 4 commits into from
Jan 20, 2022
Merged

Add 1inch to dex.trades on polygon #625

merged 4 commits into from
Jan 20, 2022

Conversation

0xtekgrinder
Copy link
Contributor

Added 1inch to dex.trades table on Polygon as requested in #606.
Results of the 1inch query can be checked at the dune_user_generated.oneinch table.

I've checked that:

  • the query produces the intended results
  • the folder name matches the schema name
  • the schema name exists in Dune
  • views are prefixed with view_, functions with fn_.
  • the filename matches the defined view, table or function and ends with .sql
  • each file has only one view, table or function defined
  • column names are lowercase_snake_cased

@masquot
Copy link
Contributor

masquot commented Dec 10, 2021

@k06a. Maybe you or someone of the team would like to review this one?

@nata-omutyanka
Copy link

  1. 37% of swaps don’t have names of tokens (only 9% of Ethereum swaps don’t have it)
  2. 2.5% of swaps has two rows. Maybe they will overstate volume (These transactions are more difficult then just swaps)

@0xtekgrinder
Copy link
Contributor Author

0xtekgrinder commented Dec 14, 2021

would it be possible to have an example of a swap that has two rows @nata-omutyanka ?

@nata-omutyanka
Copy link

For example \x00cecbd9332c235b07f8088b18072c6dbb0d4ed19faf3d4b0756cb63e2e90a6c
\x096ffb3f726dfbeef5bb2f1c62dce4416d26c112fb8871f633003a3e4da70d19

@0xtekgrinder
Copy link
Contributor Author

0xtekgrinder commented Dec 16, 2021

To keep you updated I've requested in another PR #648 . It will resolve the missing swaps that don't have the names of tokens. And I changed a bit the trade_id so that you can only query all rows where trade_id = 1 to don't get any duplicates. I've updated the dune_user_generated.oneinch and will once again the new token prices will be merged @nata-omutyanka

@0xtekgrinder
Copy link
Contributor Author

ok just to keep you updated @nata-omutyanka the PR has been merged so now it should be good :)

@k06a
Copy link
Contributor

k06a commented Jan 18, 2022

What's the state of this PR?

@0xtekgrinder
Copy link
Contributor Author

I think everything is good

@masquot masquot merged commit e277e4e into duneanalytics:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants