Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification height option #207

Closed
wfdewith opened this issue Dec 12, 2014 · 3 comments
Closed

Add notification height option #207

wfdewith opened this issue Dec 12, 2014 · 3 comments

Comments

@wfdewith
Copy link
Contributor

Since the line_height option doesn't work like it is supposed to, because it sets the line spacing rather than the height of the line itself (see #104), I would like to have an option to set the height per notification.

I am willing to do this myself, but will it be accepted as a pull request?

@knopwob
Copy link
Member

knopwob commented Dec 17, 2014

Yes, I would merge such a pull request. Just try to keep the default the same way it is now, so nothing changes in behaviour for people who don't configure this option.

@wfdewith
Copy link
Contributor Author

I believe you can close this issue and #104 now

@hughdavenport
Copy link

I believe this can be closed now?

Cheers,

Hugh

@wfdewith wfdewith closed this as completed Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants