Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Flash light when Spalsh Screen Zoom begins #12

Open
AdrKacz opened this issue May 4, 2023 · 6 comments
Open

馃悰 Flash light when Spalsh Screen Zoom begins #12

AdrKacz opened this issue May 4, 2023 · 6 comments

Comments

@AdrKacz
Copy link
Contributor

AdrKacz commented May 4, 2023

First of all, thank you very much for this A.WE.SOME plugin 馃帀馃帀馃帀

I'm using the "Zoom" splash screen, and when it starts, there is a blinking light.
I followed your guide in the README (so I set to None the Boot Splash).

Here is a video of what happen:

RPReplay_Final1683194153.mov

Do you have an idea on how to solve it? I looked at your code thinking that the color background color was initialized to WHITE, but that's not the case..

Thank you

@AdrKacz
Copy link
Contributor Author

AdrKacz commented May 4, 2023

I set the Boot Slash color to RED to see a phenomenon. It looks like there is a short amount of time between the "Default Void Boot Splash" (our RED screen) and the start of the Zoom Splash screen, where there is nothing, so it display the default background color which is light gray.

Screen.Recording.2023-05-04.at.11.03.49.mov

@AdrKacz
Copy link
Contributor Author

AdrKacz commented May 4, 2023

The issue comes from the fact that the Spash Container remove all nodes at ready and then add them back.
I manage to locally resolve the porblem by simply removing all the code that add or remove the nodes.
However that works only because I have only one splash screen.
I'll try to come up with a PR to update the code to work anyways, let me know if my intuition sounds good to you (I know almost nothing about your codebase so I may have miss the deep reason why you are removing the nodes)

@AdrKacz
Copy link
Contributor Author

AdrKacz commented May 4, 2023

Note: my method removes the transitions, so it doesn't work...

I ended up making a very small adjustment only. Instead of having SplashContainer the root of the scenes, I changed it for a Control. So I have:

Control
    ColorRect (this one has BLACK background -- or whatever you want so you don't have the light gray you don't want)
    SplashContainer
        SplashZoom

@duongvituan
Copy link
Owner

Hi, thank you very much for letting me know.
Just like you said, it's likely because I deleted and re-added it.

You can quickly fix it without editing the code with the trick:
Screen Shot 2023-05-04 at 17 43 57

@duongvituan
Copy link
Owner

As for the original idea, I'm wanting it to work in flow:

for screen in list_screen:
# Pseudocode:
# Remove old splash if need
# Add next splash screen in list_screen, config splash...
# Play animation transitions if need.
# Play splash screen animation
# ...

But it throws a blink error on the first frame, 馃槄
maybe in the future I will try to edit this flow again.

@AdrKacz
Copy link
Contributor Author

AdrKacz commented May 4, 2023

I probably don't know enough to help you, but if I'd be happy to commit some code if needed 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants