You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In duo_client/admin.py, there are get_user_groups and get_user_groups_iterator which (via json_paging_api_call in duo_client/client.py) seem to be doing the pagination for us (kinda already touched on in #63).
What I'm opening an issue over is, get_group_users looks the same as get_user_groups from the docs https://duo.com/docs/adminapi#v2-groups-get-users. ("Same" as in, both API calls take optional paging-related parameters, with limits of 100/500 defined; obviously they return different data.) But there's no similar iterator/listmaker offered for get_group_users - you get back one limit-sized slurp of data. I'm not seeing the metadata get to me from a call to get_group_users in order to manage my own pagination, but that could be an error on my part.
If it's an oversight that get_group_users doesn't page, well, here's a request. If it's deliberate, is there something you can maybe drop in a comment for why this call is seemingly unique/different?
Thanks!
The text was updated successfully, but these errors were encountered:
Hi,
In
duo_client/admin.py
, there areget_user_groups
andget_user_groups_iterator
which (viajson_paging_api_call
induo_client/client.py
) seem to be doing the pagination for us (kinda already touched on in #63).Minor note: per https://duo.com/docs/adminapi#retrieve-groups-by-user-id,
get_user_groups
should have limits of 100/500, but the API shows None. I don't particularly care here - you're doing the paging for me, so, "cool!"What I'm opening an issue over is,
get_group_users
looks the same asget_user_groups
from the docs https://duo.com/docs/adminapi#v2-groups-get-users. ("Same" as in, both API calls take optional paging-related parameters, with limits of 100/500 defined; obviously they return different data.) But there's no similar iterator/listmaker offered forget_group_users
- you get back one limit-sized slurp of data. I'm not seeing the metadata get to me from a call toget_group_users
in order to manage my own pagination, but that could be an error on my part.If it's an oversight that
get_group_users
doesn't page, well, here's a request. If it's deliberate, is there something you can maybe drop in a comment for why this call is seemingly unique/different?Thanks!
The text was updated successfully, but these errors were encountered: