Redirect to login if session isn't valid

[boarder2]

• I have searched open and closed issues for duplicates.

---

Environment info

• Duplicati version: 2.0.4.5_beta_2018-11-28
• Operating system: N/A
• Backend: N/A

Description

Currently if the UI is password protected and you try to access the site without authenticating, the site will display an information message that says "Not logged in". You have to click with the mouse on the OK button which will redirect you to the login page.

It seems more desirable to just redirect the client to the login page immediately so the user can just start typing the password to log in.

Steps to reproduce

1. Password protect the UI
2. Try to access the site

• Actual result:
  Presented with a dialog indicating that you're not logged in.
  

• Expected result:
  Redirected to the login page immediately.

[Pectojin]

It's fairly easy to implement the change but I'm wondering if there's a reason it was implemented this way.

Perhaps something about redirect loops?

[boarder2]

I tried changing the code here

duplicati/Duplicati/Server/WebServer/AuthenticationHandler.cs

Line 331 in a0af8d0

response.Status = System.Net.HttpStatusCode.Unauthorized;

To just response.Redirect("login.html") and it caused the service to not be able to start due to too many redirects.

Looks like maybe there's some stuff in TrayIcon's HttpServerConnection that might handle the Unauthorized response specifically.

I'm definitely not familiar with this code at all, but if anyone can provide some insight into what might need to change, I might be willing to put some time into trying to get this done