Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodCast Entry and functionality #17

Merged
merged 22 commits into from Mar 25, 2022
Merged

Conversation

ElCapitanDre
Copy link
Contributor

Hey, I'm probably not alone when saying this, but I'm a podcast fan, and thought that maybe you guys would like this functionality.

So I created an entry in the menu for podcasts.

Check it out, and see if its to your liking.

(First contribution to a repo that isn't mine, so if you see anything that isnt quite up to spec, let me know!)

image

image

image

@dupontgu
Copy link
Owner

Looks rad up front - will review closer when I get a little more time. Totally fine with this getting pulled in to master.

@ElCapitanDre
Copy link
Contributor Author

ElCapitanDre commented Feb 21, 2021

Looks rad up front - will review closer when I get a little more time. Totally fine with this getting pulled in to master.

Great. Have also been working on the settings menu, for wi-fi, bluetooth, etc. Been also lacking on time, so that one probably will take a little longer XD. Thanks for the feedback, and thanks for giving me a new play toy to brighten up these quarantine days! 🤣

@rsappia
Copy link
Contributor

rsappia commented Feb 21, 2021

@ElCapitanDre thanks for sharing! I tested yout podcast code and runs great!

I was thinking, it would be great to have a menu item to shutdown the ipod. On the other hand, a menu item called "Sync" to call the method refresh_data() whenever the user wants :).

The other functions you mentioned would be great to round up the design :)))

I am working now on the power management side, will share circuits as soon as I am ready.

@dupontgu
Copy link
Owner

Hey! Sorry for the long delay, and sorry you ended up with conflicts (They should be minimal)! I'm cool to merge this once you update. No rush.

@ElCapitanDre
Copy link
Contributor Author

Sorry for the delay in the response but I think I resolved all conflicts. No rush, merge when you want it ;)

@ruvido
Copy link

ruvido commented Mar 23, 2022

Hi, thanks for the update.

Is it merged now on master?

Thanks

@ElCapitanDre
Copy link
Contributor Author

Hey @ruvido it isnt yet. I think only @dupontgu can do that as of now

@dupontgu
Copy link
Owner

Sorry for holding things up. Will merge now.

@dupontgu dupontgu merged commit 267792b into dupontgu:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants