Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minification of frontend JS ressources #257

Open
sque89 opened this issue Mar 24, 2023 · 6 comments · Fixed by #261
Open

Minification of frontend JS ressources #257

sque89 opened this issue Mar 24, 2023 · 6 comments · Fixed by #261
Assignees

Comments

@sque89
Copy link

sque89 commented Mar 24, 2023

I know it wouldn't save a lot, but is there a specific reason why the scripts loaded on the frontend are not minified? If no, could that be added? I would provide a PR but first it would be good to discuss what the preferred approach would be.

Thanks!

@morvy
Copy link
Contributor

morvy commented Mar 24, 2023

I also think the scripts should be minified. Plugin could respect SCRIPT_DEBUG constant and load formatted scripts only if it's set to true.

@duracelltomi
Copy link
Owner

I would be happy to add this, could someone help me wringing the corresponding scripts?

@morvy
Copy link
Contributor

morvy commented Apr 3, 2023

you mean something like Gulp script to generate minified versions?

@sque89
Copy link
Author

sque89 commented Apr 3, 2023

@duracelltomi @morvy provided a PR. Happy to receive some feedback.

@duracelltomi
Copy link
Owner

Thanks for the quick addition!
I am just in the work on closing dev on v1.17, I will check back a bit later to this PR

@sque89
Copy link
Author

sque89 commented Apr 14, 2023

@duracelltomi any news on this one?

@morvy morvy mentioned this issue Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants