-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced conversion email/phone prepping before hashing #321
Comments
Hi, Thanks for pointing this out. Have you tried to place an order entering an email address that doesn't fulfill any of those requirements? |
Hi. |
Thanks! v1.20 will be released tomorrow, although this code seems to me a low risk change, I will add it into either 1.20.1 or 1.21 |
@StSaens @duracelltomi how should be an empty email handled? Now even empty string is hashed and empty string does generate a hash, so I believe this is not correct too. I have this in my "hotfixes":
|
Partly done: 4aad785 TODO:
|
... and 3f141f0 |
I've added better normalization into the next version: However I have doubts adding phone number formatting as it seems to be a more complex code that I though. I've found this library but adding this to GTM4WP would be a large addition for one specific feature: Currently, I think some sort of normalization should be added into WooCommerce itself so that all plugins can benefit from the results. |
Great that the email formatting is implemented. Happy with that. Should be enough for most eCommerce shops. With regards to the phone nr. That will mean that, unless the customer inputs it exactly right, Google won't be able to match that hash for enhanced conversion tracking. Maybe this should be clarified somewhere in gtm4wp docs. |
@morvy customerBillingEmailHash is not the right variable to use. Variables in orderData are filtered to prevent hashing of empty strings. I will fix this with customerBillingEmailHash too |
Hi,
I glanced at some code changes you made for enhanced conversion reporting. As an FYI, you can't just hash the email and assume it's done.
Google has (almost hidden for whatever reason) a few steps to do before it's hashed. See: https://developers.google.com/google-ads/api/docs/conversions/enhanced-conversions/web
Maybe you have implemented this. I only glanced at some changes superficially.
I don't know why they haven't signaled this in various documents more clearly, but it is what it is.
The text was updated successfully, but these errors were encountered: