Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the SL and SR buttons on the attachment rails #8

Closed
atofigh opened this issue Sep 7, 2018 · 7 comments
Closed

Support for the SL and SR buttons on the attachment rails #8

atofigh opened this issue Sep 7, 2018 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@atofigh
Copy link

atofigh commented Sep 7, 2018

When using a single joycon, the SL and SR buttons are quite useful. I tinkered with the code a bit and it looks like there is distinct signals detected, just that the code is not set up to handle that type of input yet.

@sam0x17
Copy link
Member

sam0x17 commented Sep 8, 2018

@atofigh yes I forgot to map these because my joycons have battery cases that cover them up! I will add this soon but top priority right now is adding full analog support.

@sam0x17 sam0x17 self-assigned this Sep 8, 2018
@sam0x17 sam0x17 added the enhancement New feature or request label Sep 8, 2018
@atofigh
Copy link
Author

atofigh commented Sep 8, 2018

Analog support sounds like an awesome feature. And thanks for sharing the code.

Just FYI, the SL and SR buttons are mapped to the dpad region with values 32 and 64 respectively.

@atofigh
Copy link
Author

atofigh commented Sep 8, 2018

Sorry, got that wrong. the values are 16 and 32.

@sam0x17
Copy link
Member

sam0x17 commented Sep 9, 2018

@atofigh thanks this saves me some time!

@sam0x17
Copy link
Member

sam0x17 commented Sep 11, 2018

@atofigh if I add this before we have config file support, what would you want those bound to by default?

@atofigh
Copy link
Author

atofigh commented Sep 12, 2018

Personally, I bound them to A and B because I just need extra buttons when using the left joycon alone. But that doesn't seem like a very natural choice. I would suggest mapping them to either LT/RT or LB/RB.

@ziobbe
Copy link

ziobbe commented Feb 1, 2019

If I understand this correctly the triggers on the xbox 360/xbox one controller are analog input so maybe it would be a nice idea to map them as full, mid and low pressure of the corresponding (l or r) trigger or full low pressure plus a nice redundant keypress.

@sam0x17 sam0x17 closed this as completed Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants