Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialization of the data #17

Closed
vlopes11 opened this issue Sep 24, 2019 · 1 comment · Fixed by #23
Closed

Initialization of the data #17

vlopes11 opened this issue Sep 24, 2019 · 1 comment · Fixed by #23
Assignees
@CPerezz

Comments

@vlopes11
Copy link
Contributor

vlopes11 commented Sep 24, 2019 •
edited
Loading

Here we are setting the first element to zero:

Hades252/src/hash.rs

Line 28 in 22fecbc

self.perm.data.push(Scalar::zero());

We need to set it to 2^(self.perm.t) - 1, according to appendix E of https://eprint.iacr.org/2019/458.pdf
@CPerezz
Copy link
Contributor

CPerezz commented Sep 24, 2019 •
edited
Loading

We can use the function two_pow_k function:
https://github.com/dusk-network/dusk-zerocaf/blob/e9703c12757dfef6e3063aaa6367073630a6ce0c/src/backend/u64/field.rs#L677
of zerocaf in order to implement something similar for curve25519-dalek::scalar::Scalar;.

@CPerezz CPerezz self-assigned this Sep 24, 2019
ZER0 added a commit that referenced this issue Sep 25, 2019
@ZER0
[WIP] Remove Permutation struct
cbb2709 
- Fix regression on `hash` to leave the first element (still need the
  proper value; it will be fixed on #17)

See also: #19, #20
CPerezz added a commit that referenced this issue Sep 26, 2019
@CPerezz
Fix errors in #17 solving process
517ad95 
This should close #17.
This solves the errors pointed out on:
d19f10a#r35245702
@ZER0 ZER0 mentioned this issue Sep 27, 2019
Merged
@ZER0 ZER0 closed this as completed in #23 Sep 27, 2019
ZER0 added a commit that referenced this issue May 7, 2020
@ZER0
[WIP] Remove Permutation struct
797b3c8 
- Fix regression on `hash` to leave the first element (still need the
  proper value; it will be fixed on #17)

See also: #19, #20
ZER0 pushed a commit that referenced this issue May 7, 2020
@CPerezz
Fix errors in #17 solving process
fe793d4 
This should close #17.
This solves the errors pointed out on:
d19f10a#r35245702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPerezz CPerezz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Constants, API and dependencies dusk-network/Hades252
2 participants
@vlopes11 @CPerezz