Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Permutation and Hash structs #20

Closed
ZER0 opened this issue Sep 25, 2019 · 0 comments
Closed

Refactor Permutation and Hash structs #20

ZER0 opened this issue Sep 25, 2019 · 0 comments
Assignees
@ZER0

Comments

@ZER0
Copy link
Contributor

ZER0 commented Sep 25, 2019

The Permutation currently contains the code for both Scalar and LinearCombination, we should probably split; plus Hash struct seems a mere wrapper to Permutation, so it might be not necessary.
@ZER0 ZER0 self-assigned this Sep 25, 2019
ZER0 added a commit that referenced this issue Sep 25, 2019
@ZER0
[WIP] Refactor Constants and API
0bfd7b7 
- Constants are now a binary dump of their memory representation

- Implements `Permutation`s separately for `Scalar` and
  `LinearCombination`

- Remove `Hash` struct

- Remove `RoundConstantsIterator`

Resolves: #19, #20
ZER0 added a commit that referenced this issue Sep 25, 2019
@ZER0
[WIP] Refactor Constants and API
8441df9 
- Constants are now a binary dump of their memory representation

- Implements `Permutation`s separately for `Scalar` and
  `LinearCombination`

- Remove `Hash` struct

- Remove `RoundConstantsIterator`

See also: #19, #20
ZER0 added a commit that referenced this issue Sep 25, 2019
@ZER0
[WIP] Remove Permutation struct
cbb2709 
- Fix regression on `hash` to leave the first element (still need the
  proper value; it will be fixed on #17)

See also: #19, #20
@ZER0 ZER0 mentioned this issue Sep 27, 2019
Merged
@ZER0 ZER0 closed this as completed Sep 27, 2019
ZER0 added a commit that referenced this issue May 7, 2020
@ZER0
[WIP] Refactor Constants and API
8136bce 
- Constants are now a binary dump of their memory representation

- Implements `Permutation`s separately for `Scalar` and
  `LinearCombination`

- Remove `Hash` struct

- Remove `RoundConstantsIterator`

See also: #19, #20
ZER0 added a commit that referenced this issue May 7, 2020
@ZER0
[WIP] Remove Permutation struct
797b3c8 
- Fix regression on `hash` to leave the first element (still need the
  proper value; it will be fixed on #17)

See also: #19, #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZER0 ZER0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZER0