Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use anyhow crate to handle plonk errors in gadgets test module #55

Closed
CPerezz opened this issue Jul 21, 2020 · 0 comments · Fixed by #60
Closed

Use anyhow crate to handle plonk errors in gadgets test module #55

CPerezz opened this issue Jul 21, 2020 · 0 comments · Fixed by #60
Assignees
@CPerezz
Labels
area:testing everything related to smoke-, unit-, integration-, performance testing type:tech-debt the issue is a tech debt that needs fixing

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Jul 21, 2020

Make the tests returns Error (as is now done in the blind bid if you need a reference).

Originally posted by @ZER0 in #54 (comment)

As it was discussed in that thread, once PLONK migrates to anyhow for error handling, we can update this fact here.
@CPerezz CPerezz self-assigned this Jul 21, 2020
@CPerezz CPerezz added area:testing everything related to smoke-, unit-, integration-, performance testing need:investigation type:tech-debt the issue is a tech debt that needs fixing labels Jul 21, 2020
@CPerezz CPerezz mentioned this issue Aug 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPerezz CPerezz

Labels
area:testing everything related to smoke-, unit-, integration-, performance testing type:tech-debt the issue is a tech debt that needs fixing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Anyhow inclusion dusk-network/Hades252
1 participant
@CPerezz