Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all legacy methods related to poseidon_slice from the repo #58

Closed
CPerezz opened this issue Aug 11, 2020 · 0 comments · Fixed by #59
Closed

Remove all legacy methods related to poseidon_slice from the repo #58

CPerezz opened this issue Aug 11, 2020 · 0 comments · Fixed by #59
Assignees
@CPerezz
Labels
status:invalid covers obsolete tasks, nonsensical issues, stuff that don't make sense (anymore)

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Aug 11, 2020

This no longer applies and was implemented for the previous versions of the crate by @vlopes11 . But I belive since we have a repo just for the Poseidon algorithm things, this is duplicated and unmantained code which should be removed.

Can you confirm @vlopes11 ?
@CPerezz CPerezz added API-design status:invalid covers obsolete tasks, nonsensical issues, stuff that don't make sense (anymore) labels Aug 11, 2020
@CPerezz CPerezz self-assigned this Aug 11, 2020
CPerezz pushed a commit that referenced this issue Aug 13, 2020
Remove legacy poseidon-related functions
fa07bf3 
As it is stated in #58 we never use this methods from this
library since they're moved to `Poseidon252` lib.

The implementations weren't even tested. So this is a clean up
of these old functions.
@CPerezz CPerezz mentioned this issue Aug 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPerezz CPerezz

Labels
status:invalid covers obsolete tasks, nonsensical issues, stuff that don't make sense (anymore)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove legacy poseidon functions from the library dusk-network/Hades252
1 participant
@CPerezz