Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Provisioners and Committee #1164

Closed
herr-seppia opened this issue Nov 30, 2023 · 0 comments · Fixed by #1166
Closed

Refactor Provisioners and Committee #1164

herr-seppia opened this issue Nov 30, 2023 · 0 comments · Fixed by #1166
Labels
module:consensus Issues related to consensus module

Comments

@herr-seppia
Copy link
Member

Summary

Current implementation of committee creation requires Provisioners to be mutable. This lead to a lof of Arc<Mutex> here and there to handle the mutability.

However, creation of a committee from Provisioners should not change the struct itself. This seems to be a tech debt, since the mutability is only required for implementation details.

Changing this, will remove the need for update_elegibility_flag at every round

Possible solution design or implementation

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:consensus Issues related to consensus module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant