Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus: Initialize second step with None #1165

Closed
herr-seppia opened this issue Dec 1, 2023 · 2 comments
Closed

consensus: Initialize second step with None #1165

herr-seppia opened this issue Dec 1, 2023 · 2 comments
Labels
module:consensus Issues related to consensus module

Comments

@herr-seppia
Copy link
Member 

          It is so because this is a default block that always has an empty hash. If not set as default, second reduction will not vote NIL.

Originally posted by @goshawk-3 in #1137 (comment)
@herr-seppia herr-seppia added type:tech-debt module:consensus Issues related to consensus module labels Dec 1, 2023
@herr-seppia herr-seppia mentioned this issue Dec 1, 2023
Merged
@goshawk-3
Copy link
Contributor

@herr-seppia This is not needed anymore after implementing #1201 . Now we always initialize Ratification step with the Validation output or keep it default in case of No Quorum

@herr-seppia
Copy link
Member Author

Close as not required anymore

@herr-seppia herr-seppia closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module:consensus Issues related to consensus module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goshawk-3 @herr-seppia