Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Laravel Lumen 5.8 #97

Closed
ThaDaVos opened this issue Mar 6, 2019 · 8 comments · Fixed by #173
Closed

Update to Laravel Lumen 5.8 #97

ThaDaVos opened this issue Mar 6, 2019 · 8 comments · Fixed by #173

Comments

@ThaDaVos
Copy link

ThaDaVos commented Mar 6, 2019

When trying to use this library with Laravel Lumen 5.8 I'm getting the following error:

Call to undefined method Laravel\Lumen\Application::group()
--
in LumenPassport.php line 88
@ThaDaVos
Copy link
Author

ThaDaVos commented Mar 6, 2019

Found fix, this
\Dusterio\LumenPassport\LumenPassport::routes($this->app);
Needs to be
\Dusterio\LumenPassport\LumenPassport::routes($this->app->router);

@ThaDaVos
Copy link
Author

ThaDaVos commented Mar 6, 2019

Made a pull-request @dusterio to update the ReadMe
#98

@ThaDaVos
Copy link
Author

ThaDaVos commented Mar 6, 2019

Now getting an error when trying to access oauth/token
Unresolvable dependency resolving [Parameter #0 [ <required> $app ]] in class Illuminate\Support\Manager

@lloricode
Copy link
Contributor

same here

@lloricode
Copy link
Contributor

resolve by this #99 then waiting for confirmation to merge

@lloricode
Copy link
Contributor

this is already solve,

@Gounlaf
Copy link

Gounlaf commented Mar 13, 2019

\Dusterio\LumenPassport\LumenPassport::routes($this->app->router); still must be done

@dezzeus
Copy link

dezzeus commented Apr 17, 2019

Still having the very same issue when providing a custom callback to LumenPassport::routes

Indeed Laravel's Passport does Route::group instead of $callback->group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants