Feature format number #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could use a bit more test coverage if possible. I also smashed these two changes together as to produce one logical change with tests. |
|
What more test coverage would you like? I added a few more. |
|
Well, I'd like to not reduce test coverage when adding new features. There's currently no code in go-humanize that isn't covered by tests. Last time I looked, this added code that wasn't covered, so it's either dead code, or bugs left to the user to discover. :) |
|
Hm, well unless code inside FormatFloat is counted and I have missed some possible inputs/outcomes, FormatInteger is just a wrapper around FormatFloat. I could add identical tests for that function as well. |
|
|
Ah I see, I will fix that. |
|
Done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been useful in a number of projects and I think go-humanize is a suitable home.
See examples here http://play.golang.org/p/LXc1Ddm1lJ
Much thanks to @gorhill for original code 馃憤