Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle MinInt64 correctly #45

Closed
stefanludwig opened this issue Jan 6, 2017 · 2 comments
Closed

Handle MinInt64 correctly #45

stefanludwig opened this issue Jan 6, 2017 · 2 comments

Comments

@stefanludwig
Copy link

Great library!

Comma(math.MinInt64) is not handled properly. Please add the following before the sign := "" line:

        // we need to handle MinInt64 separately
        if v == math.MinInt64 {
                return "-9,223,372,036,854,775,808"
        }
@dustin dustin closed this as completed in 904a494 Jan 6, 2017
@dustin
Copy link
Owner

dustin commented Jan 6, 2017

Thanks for the report. I've run into this class of problem in C code years ago and just almost had a test case for it. I fixed the test case bug.

@stefanludwig
Copy link
Author

Sweet! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants