Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chmod hack in darwin-build seems to be unnecessary #22

Closed
isker opened this issue Nov 6, 2023 · 2 comments
Closed

chmod hack in darwin-build seems to be unnecessary #22

isker opened this issue Nov 6, 2023 · 2 comments

Comments

@isker
Copy link

isker commented Nov 6, 2023

Hi. Thanks for maintaining this excellent repo. I am not using it directly, but it's guiding my own setup.

I ran into the problem that this is trying to handle:

# Check if the directory exists before running chmod
if [ -d "/opt/homebrew/Library/Taps" ]; then
sudo /bin/chmod +a "dustin allow list,add_file,search,delete,add_subdirectory,delete_child,readattr,writeattr,readextattr,writeextattr,readsecurity,writesecurity,chown" /opt/homebrew/Library/Taps/homebrew/
else
echo "${RED}The directory /opt/homebrew/Library/Taps/homebrew/ does not exist. Skipping chmod.${CLEAR}"
fi

And found this discussion here zhaofengli/nix-homebrew#9 (comment). I followed the suggestion about tapping homebrew-bundle in nix, and it works. This seems like a better approach than what darwin-build is doing, as far as my understanding of the situation goes 🌞.

So, maybe you want to do the same; this is just FYI.

@dustinlyons
Copy link
Owner

Oh wow, this is huge! Thanks for taking the time to let me know; I hated writing this hack 😂

I've updated the configuration. What an eloquent solution.

@dustinlyons
Copy link
Owner

Confirmed this works for me as well. Soooo happy I get to remove that incredibly egregious chmod 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants