Shell script evidence stopped working with 1.6.3

[eidermar]

As reported by another user on the google groups the shell script evidence source seems to be broken with the recent update. My script was working perfectly until recent 1.6.3 update and stopped returning a positive result when true:

#!/bin/sh

for ip in 192.168.0.{30..32}; do ping -t 1 $ip > /dev/null && echo "${ip} is up"; done

Thanks for your support!

[dustinrue]

The evidence source hasn't changed in 11 months...can you try http://www.controlplaneapp.com/download/1.6.2 and see if it starts working again?

[eidermar]

I tried. It's working in 1.6.1 but it's not working in either 1.6.2 or 1.6.3
For the moment I'm rolling back to 1.6.1 to keep it functional. Is there any risk with this version regarding sparkle framework?

[dustinrue]

Yes, 1.6.1 has the sparkle issue. 1.6.2+ are the only versions compiled on newer versions of Xcode so I'm guessing that's the issue.

[wallneradam]

I have the same issue. The scripts are called, but the results never interpreted as true.

[dustinrue]

I just pushed an update, try it and let me know if it's working better for you now.

[eidermar]

Thank you for the update. Unfortunately still not working on my side. Script is called without an error but always returned as false.

[BashfulBits]

I'm seeing the same behavior (Shell script evidence sources work in 1.6.1, broken in 1.6.2, semi-functional in 1.6.4). In my case, the script in question that was working is run with the applescript interpreter:
#!/usr/bin/osascript

with an error or return line, which then returns 1 or 0 to the shell as verified with echo $? after calling the script.
1.6.1: Works (returns correct value in evidence sources based on script logic)
1.6.2: Broken (always shows as false in evidence sources)
1.6.4: Broken (always shows as false in evidence sources)

To test, I then created two bash scripts that return 0 or 1:
#!/bin/bash exit 0

#!/bin/bash exit 1

1.6.1: Works (first script returns true in evidence sources, second one is false)
1.6.2: Broken (both scripts always show false in evidence sources)
1.6.4: Works (first script returns true in evidence sources, second one is false)

[dustinrue]

1.6.2 simply doesn't work, this is confirmed. Apple clearly changed the behavior of NSTask but it isn't documented. Using echo $? won't work because...reasons with how NSTask is working. If you exit $? it might work however. As it is now, you can either echo 0 or 1 or exit with 0 or 1 to get the expected behavior. Using echo $? is going to fail.

[BashfulBits]

Thanks for the hint. Just in case others are running into issues with applescripts used as evidence sources, I was able to workaround this with the following (assuming shouldExit indicates whether the output of the script should fail):

1.6.1 and earlier, I could exit an applescript and have it interpreted as success or failure like this:

#!/usr/bin/osascript
if shouldExit = "fail" then
   error "Exiting with failure"
else
   return "Exiting with success"
end if

With 1.6.2+, I can workaround with the following change:

#!/usr/bin/osascript
if shouldExit = "fail" then
   log "Exiting with failure"  -- Not necessary, but useful for terminal output
   error "1"
else
   log "Exiting with success"  -- Not necessary, but useful for terminal output
   return "0"
end if

Is this something that should be filed with Apple?

[fnurl]

Thanks @dustinrue for the info and @ericpruett for the tip.

@dustinrue Perhaps the info in the interface could be changed to reflect the change in behavior.

[fnurl]

I also just noticed that exit 0 and exit 1 work with bash but not with zsh...

[noaho]

I have the same problem. I can't get Shell scripts to execute either, they bomb out with (script terminated with a non-zero status '127').

I use zsh.

[dustinrue]

At the top of your script you adding #!/bin/zsh?

[noaho]

Thanks @dustinrue, I tried this and now it works, but it seems like the path is not being loaded. Eg my command fails unless I run /usr/local/bin/vagrant, while if I run the script normally, vagrant by itself is enough.

[dustinrue]

I'm not surprised. I'm almost positive the scripts are run through bash specifically so your environment isn't going to be loaded when you ask bash to run zsh to run your script. What you can do is, after the #!/bin/zsh, is source your zsh environment files. source $HOME/.zshrc for example. I'm not completely familiar with zsh so your personal profile scripts might be named differently.