Skip to content
This repository has been archived by the owner on Sep 11, 2018. It is now read-only.

Making redux-devtools less intrusive. #167

Closed
hairychris opened this issue Nov 8, 2015 · 4 comments
Closed

Making redux-devtools less intrusive. #167

hairychris opened this issue Nov 8, 2015 · 4 comments

Comments

@hairychris
Copy link

It is very obtrusive at the moment, is it worth considering how to fix it?

Option 1
Use it as a chrome extension, then it can be turned off when you don't need it.
https://github.com/zalmoxisus/redux-devtools-extension

Good: gets out of the way totally unless needed, can be used in production more easily if need be.
Bad: can't use anywhere that doesn't allow chrome (although will work on chrome mobile)

Option 2
Set visible onload to false:
reduxjs/redux-devtools#44

Good: again get's right out of the way, can be brought back with a simple ctrl+h
Bad: we need to communicate to developers that ctrl+h will bring up the developer panel

@dvdzkwsk
Copy link
Owner

dvdzkwsk commented Nov 8, 2015

What about reverting the default dev/start command to not include devtools, and then optionally enabling it with --debug or dev:debug (how it used to be)? It's closer to your option #2, but puts the decision in the CLI with documented commands.

Edit: I personally rarely use the devtools, and made them default only by request quite a while ago, so I wouldn't be opposed to this in the slightest.

@fuczak
Copy link
Contributor

fuczak commented Nov 9, 2015

Seems like a matter of preference, maybe a poll would be a good idea to see what's generally preferred?

@dvdzkwsk
Copy link
Owner

dvdzkwsk commented Nov 9, 2015

@hairychris thinking about it, I'm a much bigger fan of option 2 since it's local to the starter kit, but I'd prefer to have it be at the CLI level. That said, I'll probably create a configuration option that people can easily change to set the onLoad visibility of the devtools.

Please refer to #168 for more discussion on this.

@dvdzkwsk dvdzkwsk closed this as completed Nov 9, 2015
@hairychris
Copy link
Author

Sounds good to me, thanks for looking at this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants