Skip to content
This repository has been archived by the owner on Sep 11, 2018. It is now read-only.

Clean starter kit #20

Closed
lifehackett opened this issue Aug 16, 2015 · 10 comments
Closed

Clean starter kit #20

lifehackett opened this issue Aug 16, 2015 · 10 comments

Comments

@lifehackett
Copy link

Thanks for creating this repo. Could you move the todo example outside the starter kit? Having an example is very useful, but if you want to use this as a starter kit, you have to remove the todo example source code. If the example were in its own folder (or own repo) it would be a lot simpler to get up and running.

Thanks!

@dvdzkwsk
Copy link
Owner

Hey, definitely agree with you; I'll clean it up in a little bit.

Edit: I am going to keep a sample reducer in there just so that the devTools will work properly, but I'll gut most of the other example stuff in terms of components/views/etc.

@lifehackett
Copy link
Author

Awesome! And thanks for the quick response and resolution

@dvdzkwsk
Copy link
Owner

Hey let me know what you think of this PR: #22

It removes all Todo components, constants, actions, and the unnecessary About view. It keeps a sample reducer/store so that devTools work and show something meaningful, but it's all pretty barebones.

@lifehackett
Copy link
Author

👍

This looks much better from a starter kit perspective. The only suggestion I'd make is having the Todo example as a separate repo (if you want) because I found your examples useful, not to mention high code quality.

Thanks again!

@dvdzkwsk
Copy link
Owner

Awesome, I'll keep the old one as a branch for now and reference it in the README in case people want to take a look. When I get some time I'll consider pulling it into separate repo like you suggested. Thanks for taking a look!

@dvdzkwsk
Copy link
Owner

This has been implemented with 82a4ee6

@ioRekz
Copy link

ioRekz commented Aug 17, 2015

The todo example was really important for me as I could learn how everything works. For example, I was wondering where to put my todo.jsx or todo-list.jsx as it's not a container nor a view.
An other branch is still very fine as long as you/we can keep the todo example synced and up to date. I hope it won't fall behind.

@dvdzkwsk
Copy link
Owner

@ioRekz I'll definitely do my best to keep it updated to reflect any changes to the starter kit. I originally planned on migrating it to another repo, but thinking about it now it almost makes sense to keep it as a branch that way people are free to switch in and out of it while learning/playing around with the starter kit.

Do you think that will work? Or were you more in favor of keeping that in the base starter kit? The example app could go either way, either it being in master with the clean slate being in a branch, or vice versa (as it is currently). The latter makes more logical sense to me, but I could see people being a bit confused by a starter kit that doesn't seem to do too much when they spin it up the first time.

@ioRekz
Copy link

ioRekz commented Aug 17, 2015

The branch is actually nice, I didn't see that a lot before but that make sense and it's already more useful for me than a separate repo. Concerning which branch should be master, I'm not sure. For me the todo example was really useful so I can show my team mates how everything works but I understand the benefit of a minimal starter kit. Time will probably tell what people are looking for.

@dvdzkwsk
Copy link
Owner

Yeah we'll just have to wait and see. I'll update the README to make the example branch more prominent and see where that takes us.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants