Skip to content
This repository has been archived by the owner on Sep 11, 2018. It is now read-only.

You should fix eslint version in package.json #36

Closed
nodkz opened this issue Aug 30, 2015 · 2 comments
Closed

You should fix eslint version in package.json #36

nodkz opened this issue Aug 30, 2015 · 2 comments

Comments

@nodkz
Copy link
Contributor

nodkz commented Aug 30, 2015

Can not start todo-example today.
Get error when run npm run dev:debug:

ERROR in ./src/reducers/todos/index.js
Module build failed: TypeError: Cannot read property 'loc' of undefined
    at getNodeIndent (/Users/nod/www/_nodejs/react-redux-todo/node_modules/eslint/lib/rules/indent.js:112:49)
    at EventEmitter.Program (/Users/nod/www/_nodejs/react-redux-todo/node_modules/eslint/lib/rules/indent.js:547:45)
    at EventEmitter.emit (events.js:129:20)
    at Controller.controller.traverse.enter (/Users/nod/www/_nodejs/react-redux-todo/node_modules/eslint/lib/eslint.js:815:25)
    at Controller.__execute (/Users/nod/www/_nodejs/react-redux-todo/node_modules/eslint/node_modules/estraverse/estraverse.js:397:31)
    at Controller.traverse (/Users/nod/www/_nodejs/react-redux-todo/node_modules/eslint/node_modules/estraverse/estraverse.js:495:28)
    at EventEmitter.module.exports.api.verify (/Users/nod/www/_nodejs/react-redux-todo/node_modules/eslint/lib/eslint.js:808:24)
    at processText (/Users/nod/www/_nodejs/react-redux-todo/node_modules/eslint/lib/cli-engine.js:199:27)
    at CLIEngine.executeOnText (/Users/nod/www/_nodejs/react-redux-todo/node_modules/eslint/lib/cli-engine.js:430:26)
    at lint (/Users/nod/www/_nodejs/react-redux-todo/node_modules/eslint-loader/index.js:26:20)
    at Object.module.exports (/Users/nod/www/_nodejs/react-redux-todo/node_modules/eslint-loader/index.js:120:7)
 @ ./src/reducers/index.js 11:13-31

Problem in eslint@1.3.1. With 1.2.1 works perfectly:

npm uninstall eslint
npm install eslint@1.2.1
npm run dev:debug 
@dvdzkwsk dvdzkwsk added bug and removed bug labels Aug 30, 2015
@dvdzkwsk
Copy link
Owner

Posted a bug report on eslint: eslint/eslint#3596

It has to do with the first line of a file being blank. I'll remove the blank line for now, but should be able to maintain eslint 1.3.1 unless it causes other problems.

@dvdzkwsk
Copy link
Owner

e99abf3 has fixed the issue for me, so let me know if you're still having problems. Hopefully eslint submits a patch soon, but this should suffice for the meantime.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants