Skip to content
This repository has been archived by the owner on Sep 11, 2018. It is now read-only.

Switch to react-hot-loader v3 #726

Closed
dvdzkwsk opened this issue Apr 18, 2016 · 14 comments
Closed

Switch to react-hot-loader v3 #726

dvdzkwsk opened this issue Apr 18, 2016 · 14 comments

Comments

@dvdzkwsk
Copy link
Owner

See @gaearon 's post here: gaearon/react-hot-boilerplate#61

@justingreenberg
Copy link
Contributor

justingreenberg commented Apr 21, 2016

@levithomason
Copy link

FYI react-hot-loader@3.0.0-beta.0 is out.

@gaearon
Copy link
Contributor

gaearon commented May 2, 2016

Better yet, beta.1 is out which fixes many longstanding issues including full RR support.

@levithomason
Copy link

Thanks for the heads up, updating.

@dvdzkwsk
Copy link
Owner Author

dvdzkwsk commented May 5, 2016

I have an ongoing branch for this but still can't seem to get it working right with react-router. Will mess with it more this weekend maybe.

@gaearon
Copy link
Contributor

gaearon commented May 5, 2016

If you think there’s an issue please file it, we’d like to know!

@levithomason
Copy link

levithomason commented May 5, 2016

@davezuko after we tried this the other day, it is suddenly working for me. I'm blaming bad npm installs since literally nothing was changed on my end besides nuking and reinstalling.

EDIT

react@15.0.2
react-dom@15.0.2
react-router@2.4.0
react-hot-loader@3.0.0-beta.1

@simonjoom
Copy link

Hi i did the react hot load integration with yur boilerplate. I can share it

@rogue-techno
Copy link

@simonjoom I'd like to see your react-hot-loader integration with this project! Thanks

@UnsungHero97
Copy link

@davezuko what happened with the react-hot-loader feature? this issue was closed, but it doesn't seem like anything changed. was this closed because react-hot-loader won't be adopted?

@levithomason
Copy link

David could answer more precisely, but I asked him offline and said it is not being implemented. He mentioned trying to remove as much code instrumentation/manipulation as possible.

@dvdzkwsk
Copy link
Owner Author

@levithomason thanks for answering that. To further clarify, since it's been in beta for so long, in order to align with simplifying this project my approach is to keep it out until it at least reaches a stable v3, at which point we can reconsider.

@jonaswindey
Copy link

What's the added value with adding react-hot-loader when we have webpack-hot-middleware for hot-reloading?

@dvdzkwsk
Copy link
Owner Author

@jonaswindey react-hot-loader transform your React components so that webpack HMR knows how to reload the individual component. Without it, all code changes bubble up to the root of the application, at which point you can re-render the entire app, but you cannot preserve local component state. This is mostly mitigated by moving most of your state to redux.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants