Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unittesting and continuations intergration #8

Open
ghost opened this issue Dec 26, 2016 · 7 comments
Open

unittesting and continuations intergration #8

ghost opened this issue Dec 26, 2016 · 7 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Dec 26, 2016

We need some unittests, I will write a few and try to run it on travisci.

@ghost
Copy link
Author

ghost commented Dec 26, 2016

#9 adds a first unittest. I am not sure though how to integrate this with travisci since we need an ssh server running and travis doesn't have that..

@dvopsway
Copy link
Owner

dvopsway commented Dec 27, 2016

@rjrhaverkamp I have done the travis part and integrated the first test case with it. It will also check the code for PEP8 guidelines. Let me know your throughs.

@dvopsway dvopsway assigned dvopsway and ghost Dec 27, 2016
@dvopsway dvopsway added this to the v2.0.0 milestone Dec 27, 2016
@ghost
Copy link
Author

ghost commented Dec 27, 2016

I am so confused.. I wrote some more tests, see #18 but code coverage decreased.. 😖

@dvopsway
Copy link
Owner

dvopsway commented Dec 27, 2016

This is fixed, issue was coverage files were not getting combined. Fixed in 9a42548

@dvopsway
Copy link
Owner

dvopsway commented Dec 27, 2016

@rjrhaverkamp Few unit test ideas:

  • Unit test using password, call ssh method directly using password. we can use another environment variable of password in travis file.
  • main method validation using key and password both.
  • Validation tests for key, password and username validation.

@ghost
Copy link
Author

ghost commented Dec 27, 2016

Thanks! Good ideas, I think the validation tests shouldn't be too hard.

We should look into pytest and tox for testing. That will make it easier and more standardised.

@ghost ghost mentioned this issue Dec 29, 2016
@dvopsway dvopsway modified the milestones: v0.2.1, v0.2.0 Dec 30, 2016
@ghost
Copy link
Author

ghost commented Dec 30, 2016

@dvopsway If you look at the screenshot, you see the code that isn't covered by tests. But it is impossible to test that code..

screenshot 2016-12-30 at 11 09 34

any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant