Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tag for 1.4 and 1.5 #29

Closed
zhsj opened this issue Jan 28, 2021 · 8 comments
Closed

Missing tag for 1.4 and 1.5 #29

zhsj opened this issue Jan 28, 2021 · 8 comments

Comments

@zhsj
Copy link

zhsj commented Jan 28, 2021

Hi, the README says "Current version is 1.5." However there's no such tag. Would you mind to create a tag?

@dvsekhvalnov
Copy link
Owner

Hi @zhsj, sure thing, thanks for catching it.

@dvsekhvalnov
Copy link
Owner

Here you go @zhsj .

@zhsj
Copy link
Author

zhsj commented Jan 28, 2021

It seems go module fails to find 1.5...

$ GOPROXY=direct go get github.com/dvsekhvalnov/jose2go@v1.5
go get github.com/dvsekhvalnov/jose2go@v1.5: no matching versions for query "v1.5"

A guess is that it wants semver pattern, like v1.5.0? Not sure however..

@zhsj
Copy link
Author

zhsj commented Jan 28, 2021

Ha it does say so, https://golang.org/ref/mod#versions

For example, v0.0.0, v1.12.134, v8.0.5-pre, and v2.0.9+meta are valid versions.

@dvsekhvalnov
Copy link
Owner

mmm... want me to add one more for v1.5.0 @zhsj ?

@zhsj
Copy link
Author

zhsj commented Jan 29, 2021

mmm... want me to add one more for v1.5.0 @zhsj ?

Yes, please. So it works for Go modules :)

@dvsekhvalnov
Copy link
Owner

Here we go, enjoy your new tag @zhsj :)

@zhsj
Copy link
Author

zhsj commented Feb 1, 2021

Thanks, it works for Go modules now.

https://pkg.go.dev/github.com/dvsekhvalnov/jose2go?tab=versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants