-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support RTL animation #77
Comments
I'd love to support this. I wonder if detecting that the document is using RTL and changing the animation direction automatically would work? E.g. by using https://developer.mozilla.org/en-US/docs/Web/CSS/:dir |
It will change only the element direction and not the animation |
Since are you using animation CSS property, the only way to change the animation direction is to use animation-direction property. Right now we can set that only on A better way to deal with that in my opinion is to set a new property ( |
Ah sorry I didn't explain my idea well. I meant that we can modify the library so that it already comes with CSS that detects if a skeleton is in a rtl document (or section), and if so apply |
Hello @saadaouad @dvtng last open PR looks good to me, please merge it and issue will be fixed, we are waiting for rtl props to skeletontheme, Thanks!! |
I had fixed this issue with this
|
First of all I'd like to thank you for this great package,
Right now there is no support for RTL skeleton animation, is there a way to add a
direction
(direction: string
, Defaults toltr
) orrtl
(rtl: boolean
Defaults tofalse
) prop on SkeletonTheme component to deal with that?Happy to help on that!
The text was updated successfully, but these errors were encountered: