Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log out button in Settings (was Lofi not connecting to spotify, displays blinking spotify logo as if I don't have it open.) #134

Closed
shubhambhatnag opened this issue Jul 1, 2021 · 22 comments
Assignees
Labels
bug Something isn't working

Comments

@shubhambhatnag
Copy link

Windows 10, recently got spotify premium on a different account that I used to use lofi on, and lofi player does not recognize spotify whether I have music playing or not.

@k8seren
Copy link

k8seren commented Aug 4, 2021

Same issue here; MacOS 11.5.1. I only have one Spotify account and Lofi doesn't detect Spotify is running. Reboots/quit & re-open have no effect. Reset Lofi to factory settings as well. Bummed I can't get it to work; this app is exactly what i've been looking for!

@stamoun
Copy link
Collaborator

stamoun commented Sep 13, 2021

If you enable debug from the settings, what does the console looks like on startup?

@stamoun stamoun added the question Further information is requested label Sep 13, 2021
@stamoun stamoun added this to High priority in Bugs Sep 13, 2021
@stamoun stamoun moved this from High priority to To close next release in Bugs Sep 13, 2021
@stamoun
Copy link
Collaborator

stamoun commented Sep 16, 2021

Fixed in v1.6.0

@stamoun stamoun closed this as completed Sep 16, 2021
Bugs automation moved this from To close next release to Closed Sep 16, 2021
@k8seren
Copy link

k8seren commented Sep 16, 2021

This is still happening in 1.6. I just updated and it's doing the same thing. I can open in Debug - what info do you want from the Debug window? I don't know what I'm looking at to send it to you but happy to paste in whatever info is helpful.

@stamoun
Copy link
Collaborator

stamoun commented Sep 16, 2021

Not fixed in v1.6.0, needs to be tested on Mac.

Could you provide the contents of the debug window (the console), if any?

@stamoun stamoun reopened this Sep 16, 2021
Bugs automation moved this from Closed to Needs triage Sep 16, 2021
@stamoun stamoun moved this from Needs triage to High priority in Bugs Sep 16, 2021
@k8seren
Copy link

k8seren commented Sep 16, 2021

Here is what I see in the console - not much unfortunately. Let me know if you need more info
Screen Shot 2021-09-16 at 12 43 42 PM
.

@k8seren
Copy link

k8seren commented Sep 16, 2021

Now it's showing more activity, looks like it might be hitting API too often
Screen Shot 2021-09-16 at 12 51 51 PM
?

@stamoun
Copy link
Collaborator

stamoun commented Sep 16, 2021

FWIW, I cannot repro this on MacOS 11.5.2 (Big Sur).

So `429' errors are from Spotify throttling the API calls (we perform one call each second for track info and one each 5 seconds for like status).

As long as you have 429 errors Lofi won't be able to update the cover and track info.
That being said, you shouldn't be throttled that often (it's very spurious and most often when you change the volume via the scroll wheel).

What does the Network tab show? It should look like the following:
network

@k8seren
Copy link

k8seren commented Sep 16, 2021

The network page does look something like that. It's probably the office VPN and/or security causing the issues on my Mac. I thought maybe the update might fix that. Thanks for taking a look - no need to spend more time when it's probably not something wrong with Lofi.

@stamoun stamoun added bug Something isn't working and removed question Further information is requested labels Sep 16, 2021
@stamoun
Copy link
Collaborator

stamoun commented Sep 16, 2021

Something I thought that you may not know that would trigger the pulsing Spotify logo...
Lofi is not a standalone player, you still need to run Spotify in the background.

It may be a could idea to check if there is a Spotify process running when launching Lofi. If not, we could launch Spotify 🤔This is probably harder than it sounds because process interaction is very OS specific.

@SpagettJP
Copy link

Not sure if this should be a separate issue but I was having the same issue. It turns out I had the wrong Spotify account connected. This was not easy to change. I had to go to ..APPDATA\ROAMING\lofi to edit the "Access Token" in the settings file to reset my login. This should be easier, unless I am missing something.

@KatyaraBlackstone
Copy link

I had to go to ..APPDATA\ROAMING\lofi to edit the "Access Token" in the settings file to reset my login.

This fix worked in my case. Many thanks!

@shubhambhatnag
Copy link
Author

How do I access my Spotify account's access token? What do I do exactly in the settings file?

@shubhambhatnag
Copy link
Author

Okay, I deleted the token from the file and relogged in through lofi, but the situation did not resolve. I still see the blinking spotify logo, even though I'm playing music through Spotify. Works with web player though.

@SpagettJP
Copy link

@BlobKnight did you have to sign back into spotify or give it permission again after you relogged the settings file?

@shubhambhatnag
Copy link
Author

I deleted the token, and when I relaunched lofi it asked me to sign in. I gave Spotify the permission but nothing changed.

@SpagettJP
Copy link

SpagettJP commented Jan 4, 2022

image
also this is the location of the settings file and the text that needs to be removed to reset the access token.
@BlobKnight you must be having a different issue. You are using the Spotify desktop client right?

Edit: I deleted the photo with my Spotify access token lol, don't want to put that out there even though it looks like a pain in the ass to type.

@SpagettJP
Copy link

@BlobKnight make sure your web client and desktop clients are signed into the same account if you are using the desktop client.

@shubhambhatnag
Copy link
Author

@SpagettJP They are on the same account

@SpagettJP
Copy link

FWIW, I cannot repro this on MacOS 11.5.2 (Big Sur).

So `429' errors are from Spotify throttling the API calls (we perform one call each second for track info and one each 5 seconds for like status).

As long as you have 429 errors Lofi won't be able to update the cover and track info. That being said, you shouldn't be throttled that often (it's very spurious and most often when you change the volume via the scroll wheel).

What does the Network tab show? It should look like the following: network

Have you followed along with this troubleshooting? If so, are you getting the 429 error?

@stamoun
Copy link
Collaborator

stamoun commented Jan 5, 2022

Not sure if this should be a separate issue but I was having the same issue. It turns out I had the wrong Spotify account connected. This was not easy to change. I had to go to ..APPDATA\ROAMING\lofi to edit the "Access Token" in the settings file to reset my login. This should be easier, unless I am missing something.

There should be a log out button in the settings window that could zap the access token from the settings file. I will reuse this issue in that regards.

@stamoun stamoun changed the title Lofi not connecting to spotify, displays blinking spotify logo as if I don't have it open. Add log out button in Settings (was Lofi not connecting to spotify, displays blinking spotify logo as if I don't have it open.) Jan 5, 2022
@stamoun stamoun added this to In progress in v2.0.0 Feb 26, 2022
@stamoun stamoun self-assigned this Mar 14, 2022
@stamoun stamoun mentioned this issue Apr 10, 2022
@stamoun stamoun moved this from In progress to On hold in v2.0.0 Apr 29, 2022
@stamoun stamoun moved this from On hold to In progress in v2.0.0 Jan 1, 2023
@stamoun
Copy link
Collaborator

stamoun commented Jan 1, 2023

Currently fixed in the electron upgrade branch.
If you reset the settings to default, it will log you out.

@stamoun stamoun moved this from In progress to To test in v2.0.0 Jan 3, 2023
@stamoun stamoun moved this from High priority to To close next release in Bugs Jan 3, 2023
@stamoun stamoun moved this from To test to Done in v2.0.0 Feb 5, 2023
@stamoun stamoun closed this as completed Apr 24, 2023
Bugs automation moved this from To close next release to Closed Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Bugs
Closed
Development

No branches or pull requests

5 participants