Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new bokeh version #9

Closed
JoelPasvolsky opened this issue Oct 16, 2020 · 1 comment
Closed

Update to new bokeh version #9

JoelPasvolsky opened this issue Oct 16, 2020 · 1 comment

Comments

@JoelPasvolsky
Copy link
Collaborator

Currently we pin to bokeh===0.12.15, it would be nice to update to the latest, 2.2.2.
However, 2.2.2 does not support Python 3.5. The previous version, which does support 3.5, is 1.4.0. Unfortunately, between 1.4.0 and 2.2.2 there is a deprecation that affects this JN: "Importing from_networkx from bokeh.models.graphs is deprecated. Import from bokeh.plotting instead."
So better to wait till after 3.5 is no longer supported.

See dwavesystems/dwave-ocean-sdk#91

I have the code change here for when we do: https://github.com/JoelPasvolsky/factoring-notebook/tree/bokeh

@randomir
Copy link
Contributor

I don't see why would this would be a blocker.

Just unpin bokeh in your requirements, so that the latest version available for the current python is installed.

And then do a conditional import by replacing line 27 on your branch with:

try:
    from bokeh.plotting import from_networkx
except ImportError:
    # handle bokeh<=1.4.0 (py35 and before)
    from bokeh.models.graphs import from_networkx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants