You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In qboost.py, the WeakClassifiers class is misleading because its fit and predict methods actually implement the AdaBoost algorithm. In demo.py, this method is then compared with AdaBoost from sklearn. In the demo.py output, "Adaboost" refers to the sklearn implementation and "Decision tree" refers to the Adaboost implementation from the WeakClassifiers class. As far as I can tell, the only real difference between the two is that the demo runs the WeakClassifiers AdaBoost method with a tree depth of 3, whereas the call to sklearn's AdaBoost model uses the default, which is a tree depth of 1.
Need to review the best way to address this. Some points to consider:
The screen output from demo.py should be updated to use a more accurate description than "Decision tree"
Perhaps remove one of the two AdaBoost implementations from demo.py
Or, if both are kept, consider using the same tree depth for consistency
Use a better class name than WeakClassifiers
Update comments/docstrings to describe what is actually being done by the different methods
The text was updated successfully, but these errors were encountered:
In qboost.py, the
WeakClassifiers
class is misleading because itsfit
andpredict
methods actually implement the AdaBoost algorithm. In demo.py, this method is then compared with AdaBoost from sklearn. In the demo.py output, "Adaboost" refers to the sklearn implementation and "Decision tree" refers to the Adaboost implementation from theWeakClassifiers
class. As far as I can tell, the only real difference between the two is that the demo runs theWeakClassifiers
AdaBoost method with a tree depth of 3, whereas the call to sklearn's AdaBoost model uses the default, which is a tree depth of 1.Need to review the best way to address this. Some points to consider:
WeakClassifiers
The text was updated successfully, but these errors were encountered: