Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake doesn't install anything #220

Open
yurivict opened this issue Aug 14, 2022 · 5 comments
Open

cmake doesn't install anything #220

yurivict opened this issue Aug 14, 2022 · 5 comments

Comments

@yurivict
Copy link

Description
There are no install instructions in the code so there is no install target for make.

Environment:

  • OS: FreeBSD 13.1
  • Python version: 3.9
@arcondello
Copy link
Member

Hi @yurivict , there are instructions for using cmake to run the tests. Otherwise this is intended to be used a header only library.

@yurivict
Copy link
Author

@arcondello Header-only libraries should also be installed. Packages are created for them and then used to build other packages.

@yurivict
Copy link
Author

The include folder contents should probably be installed into include/minorminer.

@boothby
Copy link
Collaborator

boothby commented Aug 27, 2022

Yuri,

The person who wrote the CMake files is no longer a contributor to this repo, and that's not my area of expertise. If you're able to contribute an installation recipe, I'll be willing to maintain it.

@yurivict
Copy link
Author

Ok, I will submit a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants