Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Insight] PHP code should follow PSR-1 basic coding standard - in src/…/lib/DdateConverter.php, line 198 #28

Closed
dweichert opened this issue Jan 24, 2016 · 0 comments
Assignees
Milestone

Comments

@dweichert
Copy link
Owner

in src/EmperorNortonCommands/lib/DdateConverter.php, line 198

Method names should be declared in camelCase. You should rename this method to comply with PSR-1.

     * In leap years for days after the 60th day of the year, i.e. 29th of
     * February there is an offset of 1 day to be taken into account.
     *
     * @return integer
     */
    protected function _getOffset($leapYear, $dayOfYear)
    {
        if ($dayOfYear < 60)
        {
            return 0;
        }

Posted from SensioLabsInsight

@dweichert dweichert self-assigned this Jan 24, 2016
@dweichert dweichert added this to the v1.0.2 milestone Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant