New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatpak release #86
Comments
I'm guessing it's not running on Fedora because of libmpv being installed in a different location or different .so file name. Building from source would probably get it running. I don't know much at all about Linux packaging (other than installing things via apt and snap), so I'm hoping someone from the community would be able to step up and volunteer for this! Though I'll look into it eventually if not |
I posted a flatpak request to their forum, see https://discourse.flathub.org/t/supersonic-lightweight-cross-platform-desktop-client-for-subsonic-music-servers/3984 |
Thanks! I am not too familiar with flatpaks, do you know if there are any git branching/tagging conventions I need to follow as a developer to play nicely with flatpak? |
I'm not sure, but I don't think so? As long as you tag releases, you should be fine. If you want to just jump into this, there's a good first steps tutorial. I doubt it will get you going though, because you'll probably need some permissions to access the network, graphical interface and so on. They also have guides for specific environments but Golang is unfortunately not in there. You'll probably need to go through at least parts of the full build guide. In any case, it looks like it's pretty well documented... I haven't gone through this process myself yet, but I've been considering it for this project considering how exciting it is. :) |
That would be awesome if you or someone else could volunteer to look into the Flatpak build guide, since I have some new features I'd like to focus on implementing and also I have my day job too :) |
Especially someone who uses Fedora, since it looks like the build steps should be simple enough to translate over (you'd probably want to omit the I think the biggest thing to figure out is what are the names of the dependency packages to install in the Flatpak environment |
i'm working on something now. so far I have this nasty blob:
it's horrible in many ways, coming from debian packaging (#129):
so it looks like the mpv headers are there, but not the shared library, ugh. |
this almost works now, so i pushed it to a repo: |
"almost" as in: it doesn't actually work. the app compiles, and i can relink it with the Fyne command, but then it crashes on startup with:
full trace:
@dweymouth any idea what could be missing in there? you mentioned something about a fork of Fyne somewhere in #129, i don't think i see that in the README instructions... what are you refering to there? The flatpak metadata file is here: it should be relatively readable, can you see if I am missing anything? |
ah, i simply needed to expose the normal x11 socket (not fallback). any chance this runs under wayland natively btw? :) |
The go build command pulls dependencies listed in the go.mod file, which will pull down my fork of Fyne. If it compiles, that's not your problem. Does Flatpack disable OpenGL access by default? If so you need to enable it. The error message looks like it failed to initialize OpenGL |
What subsonic server are you using? Does it work with the Navidrome demo server? #112 seems to be that MPV itself chokes on some playback URLs from airsonic, but I have never seen it with Navidrome |
Navidrome.
Untested, but I did manage to make Supersonic work outside of the flatpak, remember, by compiling from git directly.
After recompiling from the latest HEAD, I do get more debug output:
but still no sound, and the "play" button turns back off after playing, so it doesn'T really work. playing the above file in mpv itself on the commandline (outside of the flatpak, not sure how to do it inside) works fine. i'm recompiling again with the latest latest (after your merge) to make sure i have the latest goods. :) after recompiling with the latest head (440dee1), i see the same behavior: the play button turns to pause momentarily and then back to "play" again and no audio comes out. |
running out of ideas on this one... if you want to reproduce the issue, install i'm at the step where i run supersonic through
|
Progress! I've been able to fix the mpv build to provide me with a
Ha! so i need to fix my mpv build, whoohoo! |
submitted this as a PR to flathub: flathub/flathub#4073 audio plays now, and the thing just generally works! the challenge now is to remove the |
Go typically builds all the Golang dependencies into the binary statically, so makes sense. |
the flatpak PR is now ready to be merged, i believe i've done everything i could on that end. so if all goes well, you should end up on flathub shortly, whoohoo! and, again, good job on this awesome client. :) |
@dweymouth the build fails because I haven't set an appstream data file... do you have one handy? see: https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html the automated flathub build failed because of that: |
the PR was merged and is now available on flathub! see https://github.com/flathub/io.github.dweymouth.supersonic for the repository and of course this page for installation instructions! https://flathub.org/apps/details/io.github.dweymouth.supersonic @dweymouth let me know if you want access to the flathub repository so you can make changes there yourself. generally, i'll make sure there's a bot that makes PRs when there are new changes upstream, but please do let me know the next time there's a release as i had to package the git version for now... thanks! |
oh and this ticket can be closed of course, although I cannot do that myself... |
Added the Flathub link to the readme. Thanks @anarcat! |
@anarcat I released a new version today. I'm not sure what is the procedure to update the Flatpak. I did update the appstream metadata file. |
On 2023-04-22 12:09:23, Drew Weymouth wrote:
@anarcat I released a new version today. I'm not sure what is the procedure to update the Flatpak. I did update the appstream metadata file.
Normally, Flathun should issue me a PR automatically, I'll wait a few
days to see if it happens, otherwise i'll just do it myself. Feel free
to remind me if i forget! :)
|
i timed out on the bot, not sure it is supposed to pick it up because i don't actually have the tag in there yet. i made flathub/io.github.dweymouth.supersonic#8 to update to v0.1.0, but i see you already have a bunch of fixes on top of that... i guess i could make a beta branch for that as well? |
what did you do to make this work? After switching to fedora for better overall arm support, I sadly lost access to a repo package of supersonic, meaning I have to rely on flatpak. |
Would it be please possible to provide a flatpak release please? Quite interested, but does not run on Fedora 37
The text was updated successfully, but these errors were encountered: