Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue Eslint error #29

Closed
gianko opened this issue Feb 10, 2018 · 8 comments
Closed

Vue Eslint error #29

gianko opened this issue Feb 10, 2018 · 8 comments
Assignees
Labels

Comments

@gianko
Copy link

gianko commented Feb 10, 2018

code:

  props: {
    color: VueTypes.string.def('black'),
  },

lint error:
Prop 'color' requires default value to be set vue/require-default-prop

@gianko gianko changed the title Vue Esilnt error Vue Eslint error Feb 10, 2018
@dwightjack
Copy link
Owner

Hi,

Thanks for the issue. I've never properly tested vue-props with latest vue-eslint-plugin.

Will check it out.

@dwightjack
Copy link
Owner

@gianko I've opened an issue on the vue-eslint-plugin repository because I'm not sure how to proceed to solve this issue.

In the meawhile the only solution I see is to disable vue/require-default-prop rule, even if I know it sucks... 😢

@gianko
Copy link
Author

gianko commented Feb 19, 2018

Yeah, I was disabling that rule.

Thanks, great library! : )

@dwightjack
Copy link
Owner

@gianko Thank you for the contribution.

I've checked with vue-eslint-plugin creators but it looks not so easy to integrate.

Will report here if I succeed in finding a viable solution.

@Xotic750
Copy link
Contributor

This is really unfortunate, this is a blocker for introducing this project to other projects that I am involved in. If I have any ideas I will be sure to contribute.

@dwightjack
Copy link
Owner

Thank you!

@dwightjack
Copy link
Owner

@gianko I've just released an ESLint plugin to make vue-types play alongside eslint-plugin-vue: https://github.com/dwightjack/eslint-plugin-vue-types

After installing it, you should just add 'plugin:vue-types/strongly-recommended' as the last extends preset in your configuration

Let me know if it works for you.

@dwightjack
Copy link
Owner

Closing this for housekeeping. Feel free to re-open it if something new happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants