Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launcher tests failing, but passing anyway #210

Closed
paulp opened this issue Mar 16, 2018 · 2 comments
Closed

Launcher tests failing, but passing anyway #210

paulp opened this issue Mar 16, 2018 · 2 comments

Comments

@paulp
Copy link
Collaborator

paulp commented Mar 16, 2018

The 0.7.7 launcher is 404, as in fact is the entirety of simple-build-tool.googlecode.com, but the test for sbt 0.7.x passes anyway. It is not immediately clear to me why, but it is not a promising sign the tests are testing.
@dwijnand
Copy link
Owner

we don't test that behaviour because we mock the curl invocation.

however I think we should consider some integration tests (#132).

@dwijnand
Copy link
Owner

Duplicate of #132

@dwijnand dwijnand marked this as a duplicate of #132 May 31, 2018
@dwijnand dwijnand mentioned this issue Jul 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulp @dwijnand