Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Can Shapes and Text Fields Stay on Whole Pixels on Resize? #38

Closed
tschmeisser opened this issue Feb 20, 2018 · 5 comments
Closed
Labels
enhancement New feature or request fixed in next release This issue has already been fixed in the next release – hang tight for it's release

Comments

@tschmeisser
Copy link

Because your padding recalculates everything, it's causing lines/strokes/shape edges to become blurry on resize. I believe this could be remedied by being super anal about maintaining everything on whole pixels, but this would be amazing. I'd just round to the nearest.

@DWilliames DWilliames added the enhancement New feature or request label Feb 24, 2018
@DWilliames
Copy link
Owner

Ah cool. Yeah that's a really good point!

In some cases though – do you thing there would be people who would want the spacing etc. to be perfect, and not aligned to the pixels?

I was thinking; maybe I'll make sure it pixel-fits to whole number if the user has set 'Pixel fitting' on in Sketch preferences. Thoughts?

screen shot 2018-02-25 at 2 14 34 am

@DWilliames DWilliames changed the title Can Shapes and Text Fields Stay on Whole Pixels on Resize? [Enhancement] Can Shapes and Text Fields Stay on Whole Pixels on Resize? Feb 24, 2018
@tschmeisser
Copy link
Author

tschmeisser commented Feb 24, 2018 via email

@DWilliames
Copy link
Owner

@trvsss No worries. It's totally do-able.

Just to clarify; is this purely for the positioning of the layers (e.g. their 'x' and 'y')?
Or is it also for their size too? (width, height)

DWilliames added a commit that referenced this issue Feb 24, 2018
@DWilliames DWilliames added the fixed in next release This issue has already been fixed in the next release – hang tight for it's release label Feb 24, 2018
@DWilliames
Copy link
Owner

I just pushed a release (v1.0.4) that should now include this. 👍

I will close this issue for now, assuming that the fix is stable — if you find that it hasn't been fixed, then please re-open this issue.

Cheers!

@tschmeisser
Copy link
Author

This is working perfectly now! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in next release This issue has already been fixed in the next release – hang tight for it's release
Projects
None yet
Development

No branches or pull requests

2 participants