Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Make :publish command to push only packages version tags #1183

Closed
ruslan-kurchenko opened this issue Dec 21, 2022 · 1 comment · Fixed by #1195
Closed

Make :publish command to push only packages version tags #1183

ruslan-kurchenko opened this issue Dec 21, 2022 · 1 comment · Fixed by #1195
Assignees
Labels
enhancement enhancement to existing feature

Comments

@ruslan-kurchenko
Copy link
Contributor

Describe the bug
In our build process, we use floating tags to specify the latest successful build commit. In some cases, we merge multiple release branches at a time. As a result, multiple publish jobs are executed, and they push all tags from the repo (if I understand it correctly). As we have floating tags, it might happen that one push tried to push a floating one into the old position (commit), resulting in job failure.

To Reproduce
Steps to reproduce the behavior:
There is no standard way to reproduce it but you would emulate it.

  • Create a tag on some old commit of the trunk. "lastest-successful-build-main" for example
  • Trigger a build process
  • Wait till the build job started
  • Quickly re-create the tag with the same name on the last commit and push it wish force param to override the position
  • Publish commit should fail (see screenshot)

Expected behavior

  • Publish command should not publish tags which are not relevant to packages' versions

Screenshots
Screenshot 2022-12-19 at 14 00 15

Platform Details (please complete the following information):

  • OS: not relevant
  • Version not relevant
  • Salesforce CLI(sfdx cli) Version: not relevant
  • CI Platform: GitLab
@github-actions github-actions bot added the analysis To be decided on how to solution/fix label Dec 21, 2022
@azlam-abdulsalam azlam-abdulsalam added enhancement enhancement to existing feature and removed analysis To be decided on how to solution/fix labels Jan 15, 2023
@azlam-abdulsalam azlam-abdulsalam linked a pull request Jan 19, 2023 that will close this issue
5 tasks
@azlam-abdulsalam
Copy link
Contributor

Added a new enhancment in January23 that resolves this issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement enhancement to existing feature
Projects
Development

Successfully merging a pull request may close this issue.

3 participants