Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency for required Text Input and Checkbox #925

Closed
idimovska opened this issue Apr 21, 2022 · 4 comments
Closed

Inconsistency for required Text Input and Checkbox #925

idimovska opened this issue Apr 21, 2022 · 4 comments
Assignees
Milestone

Comments

@idimovska
Copy link

idimovska commented Apr 21, 2022

There is an inconsistency if we need a Text input and Check box to be mandatory fields(required).
For Check box there is a required:boolean prop (If true, the checkbox will change its appearence, showing that the value is required.)
For Text Input it is missing such a prop required. There is an optional: boolean prop (If false, will be considered required )

The 2 types of fields look really different and inconsistent: the Check box has a red asterisk and the Text Input has not(if optional=false).

Expected behavior
Unify the look of the 2 components if the field is required(mandatory).

2022-04-21 16_14_35

@jsardid
Copy link
Member

jsardid commented Apr 22, 2022

You are totally right, these two systems shouldn't be living at the same time.
We are planing a redesign for the checkbox component which includes replacing required with optional. But this redesign won't happen at least for some months. @aweell do you think we can bring the optional functionality now (before the redesign)?

@aweell
Copy link
Collaborator

aweell commented Apr 25, 2022

Thanks @idimovska for your feedback!

100% on this, we can split the redesign into two stages, prioritize making a quick fix to the required prop in order to keep consistency, and then allocate the rest of the epic tasks in another release.

@GomezIvann GomezIvann self-assigned this Apr 25, 2022
@jsardid jsardid added the epic label Apr 25, 2022
@jsardid jsardid added this to the 22.2 milestone Apr 25, 2022
@GomezIvann
Copy link
Collaborator

GomezIvann commented Apr 25, 2022

I split this issue since we need to fix this in more than one component:

@GomezIvann
Copy link
Collaborator

GomezIvann commented Apr 28, 2022

A new optional prop has been added to replace required in Switch and Checkbox components, for consistency between Halstack form components.

image
image

@jsardid jsardid changed the title Inconsistency for required Text Input and Checkbox s May 10, 2022
@jsardid jsardid changed the title s Inconsistency for required Text Input and Checkbox May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants