Bug - Adding contracts with wrong signature/interface breaks templateLauncher#handleTemplateAdded

[adamazad]

Context

TemplateLauncher.addTempate(address templateAddress) expects, in good faith, that the received contract is implementing the method templateName -- which names the template.

Transaction 0x59398c2374b35 adds, by mistaken, a FixedPriceSale sale module to TemplateLauncher. The call emits TemplateAdded, the subgraph picks up the event. However, when trying to process the event, the signature/method templateName does not exist on . and the subgraph fails to sync any further blocks.

Solution

Contract-level

Check the address interface for matching signature before adding the template. This is also critical to document for people building on top of Aqua.

Subgraph-

Check if the address implements the templateName method. A try/catch could help.

[adamazad]

Findings:

• Handling Dynamic Data Sources with unknown ABIS graphprotocol/graph-node#892
• INFO Possible reorg detected graphprotocol/graph-node#2199
• Expose reverts to mappings graphprotocol/graph-node#1139
• Handling function signatures with varying return values  graphprotocol/graph-node#1376
• invalid argument 1: hex string without 0x prefix graphprotocol/graph-node#2319

This has to be fixed at contract level; EVM should the source of truth for Web3.

[adamazad]

Closed via cryptonative-ch/aqua-smartcontracts#123