fix: make lockfile practice only for js and ts

DXHeroes · Jan 27, 2021 · 660cd0b · 660cd0b
1 parent d11eb01
commit 660cd0b
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 12 deletions.
diff --git a/...agement/LockfileIsPresentPractice.spec.ts → ...cript/JsLockfileIsPresentPractice.spec.ts b/...agement/LockfileIsPresentPractice.spec.ts → ...cript/JsLockfileIsPresentPractice.spec.ts
@@ -1,5 +1,5 @@
-import { LockfileIsPresentPractice } from './LockfileIsPresentPractice';
-import { PracticeEvaluationResult } from '../../model';
+import { JsLockfileIsPresentPractice } from './JsLockfileIsPresentPractice';
+import { PracticeEvaluationResult, ProgrammingLanguage } from '../../model';
 import { TestContainerContext, createTestContainer } from '../../inversify.config';
 import shelljs from 'shelljs';
 import { sync as commandExists } from 'command-exists';
@@ -16,11 +16,11 @@ jest.mock('command-exists', () => ({
 
 describe('LockfileIsPresentPractice', () => {
   let containerCtx: TestContainerContext;
-  let practice: LockfileIsPresentPractice;
+  let practice: JsLockfileIsPresentPractice;
 
   beforeAll(() => {
     containerCtx = createTestContainer();
-    containerCtx.container.bind('LockfileIsPresentPractice').to(LockfileIsPresentPractice);
+    containerCtx.container.bind('LockfileIsPresentPractice').to(JsLockfileIsPresentPractice);
     practice = containerCtx.container.get('LockfileIsPresentPractice');
   });
 
@@ -60,11 +60,24 @@ describe('LockfileIsPresentPractice', () => {
     expect(evaluated).toEqual(PracticeEvaluationResult.unknown);
   });
 
-  it('Is always applicable', async () => {
-    const result = await practice.isApplicable();
+  it('Is applicable to JS', async () => {
+    containerCtx.practiceContext.projectComponent.language = ProgrammingLanguage.JavaScript;
+    const result = await practice.isApplicable(containerCtx.practiceContext);
     expect(result).toEqual(true);
   });
 
+  it('Is applicable to TS', async () => {
+    containerCtx.practiceContext.projectComponent.language = ProgrammingLanguage.TypeScript;
+    const result = await practice.isApplicable(containerCtx.practiceContext);
+    expect(result).toEqual(true);
+  });
+
+  it('Is not applicable to other languages', async () => {
+    containerCtx.practiceContext.projectComponent.language = ProgrammingLanguage.Python;
+    const result = await practice.isApplicable(containerCtx.practiceContext);
+    expect(result).toEqual(false);
+  });
+
   describe('fixer', () => {
     let npmInstallRun: boolean;
     let yarnInstallRun: boolean;

diff --git a/...geManagement/LockfileIsPresentPractice.ts → ...JavaScript/JsLockfileIsPresentPractice.ts b/...geManagement/LockfileIsPresentPractice.ts → ...JavaScript/JsLockfileIsPresentPractice.ts
@@ -1,5 +1,5 @@
 import { IPractice } from '../IPractice';
-import { PracticeEvaluationResult, PracticeImpact } from '../../model';
+import { PracticeEvaluationResult, PracticeImpact, ProgrammingLanguage } from '../../model';
 import { DxPractice } from '../DxPracticeDecorator';
 import { PracticeContext } from '../../contexts/practice/PracticeContext';
 import { PackageManagerUtils, PackageManagerType } from '../utils/PackageManagerUtils';
@@ -13,9 +13,11 @@ import shell from 'shelljs';
   reportOnlyOnce: true,
   url: 'https://dxkb.io/p/lockfile',
 })
-export class LockfileIsPresentPractice implements IPractice {
-  async isApplicable(): Promise<boolean> {
-    return true;
+export class JsLockfileIsPresentPractice implements IPractice {
+  async isApplicable(ctx: PracticeContext): Promise<boolean> {
+    return (
+      ctx.projectComponent.language === ProgrammingLanguage.JavaScript || ctx.projectComponent.language === ProgrammingLanguage.TypeScript
+    );
   }
 
   async evaluate(ctx: PracticeContext): Promise<PracticeEvaluationResult> {

diff --git a/src/practices/index.ts b/src/practices/index.ts
@@ -1,7 +1,7 @@
 import { TypeScriptUsedPractice } from './JavaScript/TypeScriptUsedPractice';
 import { PrettierUsedPractice } from './JavaScript/PrettierUsedPractice';
 import { ESLintUsedPractice } from './JavaScript/ESLintUsedPractice';
-import { LockfileIsPresentPractice } from './PackageManagement/LockfileIsPresentPractice';
+import { JsLockfileIsPresentPractice } from './JavaScript/JsLockfileIsPresentPractice';
 import { JsFrontendTestingFrameworkUsedPractice } from './JavaScript/JsFrontendTestingFrameworkUsedPractice';
 import { JsLoggerUsedPractice } from './JavaScript/JsLoggerUsedPractice';
 import { LicenseIsPresentPractice } from './LanguageIndependent/LicenseIsPresentPractice';
@@ -49,7 +49,7 @@ export const practices = [
   PrettierUsedPractice,
   ESLintUsedPractice,
   ESLintWithoutErrorsPractice,
-  LockfileIsPresentPractice,
+  JsLockfileIsPresentPractice,
   JsFrontendTestingFrameworkUsedPractice,
   JsBackendTestingFrameworkUsedPractice,
   JsLoggerUsedPractice,