Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for each version control service #10

Closed
Jakub-Vacek opened this issue Sep 18, 2020 · 3 comments
Closed

Add icons for each version control service #10

Jakub-Vacek opened this issue Sep 18, 2020 · 3 comments
Labels
good first issue Good for newcomers Status: Available Issue is available

Comments

@Jakub-Vacek
Copy link
Collaborator

Each version control service has its logo. Logo is displayed in configuration and pipeline list next to repository name.
Depends on #6

@Jakub-Vacek Jakub-Vacek added Status: Available Issue is available good first issue Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com labels Sep 21, 2020
@prokopsimek prokopsimek removed the Hacktoberfest https://hacktoberfest.digitalocean.com label Nov 5, 2020
@kucharzykt
Copy link
Contributor

Hello, I tried to create a pull request to fix this issue, but I am not able to create a pull request from my commit. Until i will figure it out here is my text for pull request:

Add icons for each version control service #10

Version control service icons added to:

  • Configuration Picker (1)
  • Saved configuration (2)
  • Pipelines in Pipeliner app (3)
  • Pipelines in Pipeliner Widget - small, medium and large (4)

Visible on the screenshots below.

pipeliner_icons_added

GitHub icon was not standing out in dark mode so I added black and also white icon. Light mode uses black and dark mode uses white icon.

pipeliner_light_mode_github

I added also Bitbucket option for the future, it is commented for now.

All the icons are from official assets(company websites), sized down to 18x18.png files. I don’t know how to resize NSImage, so after some time I resized the icons. If there is some simple solution I will be very happy to learn about it.


⚠️I had to add assets into build phases for Pipeliner and PipelinerWidget to be able to load the icons. It is not commited in github

assets_build_phases_pipeliner
assets_build_phases_widget

I also added serviceType to PipelineResult, so I can load icon according to type for widget pipelines.

I hope that this changes will be useful.

BR,
Tom.

@Jakub-Vacek
Copy link
Collaborator Author

Hi 👋 Great job 👍I like white & black logo detail 🙂I can see png icons in Assets.xcaassets folder which I fine. Also i think you committed some of yours user data.../project.xcworkspace/xcuserdata/tomaskucharzyk.xcuserdatad/UserInterfaceState.xcuserstate which is unnecessary. Otherwise your PR is fine.

@kucharzykt
Copy link
Contributor

Thank you 🙂 should i remove the file? Or it is okay and i can leave it there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Status: Available Issue is available
Projects
None yet
Development

No branches or pull requests

3 participants