This repository has been archived by the owner on Jul 27, 2021. It is now read-only.
Opinionated style for dxos modules. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinchoz49
force-pushed
the
tinchoz49-style
branch
from
499fb94
to
f27098f
Compare
tinchoz49
force-pushed
the
tinchoz49-style
branch
from
f27098f
to
309f73e
Compare
| @@ -2,6 +2,11 @@ | |||
|
|
|||
| > A consistent store for your hypercore feeds. | |||
|
|
|||
| [](https://travis-ci.com/dxos/feed-store) | |||
| [](https://coveralls.io/github/dxos/feed-store?branch=tinchoz49-style) | |||
| [](https://github.com/standard/semistandard) | |||
There was a problem hiding this comment.
This is going to be really painful but it's the right decision.
I'm just sad that so many people on the internet are wrong.
There was a problem hiding this comment.
at least we are going to have something in common with these companies: https://standardjs.com/#who-uses-javascript-standard-style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR show an example of an opinionated style:
semistandardto provideStandard with semicolons. At least we can be close to the community in that way.