Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog animation for pre-Lollipop (Android 4.3) #10

Closed
GarciaPL opened this issue Oct 22, 2015 · 15 comments
Closed

Dialog animation for pre-Lollipop (Android 4.3) #10

GarciaPL opened this issue Oct 22, 2015 · 15 comments

Comments

@GarciaPL
Copy link

Hi,

I am using your library in Android app which is compiled to Android SDK version 23. I am running this app on Android 4.3. As far I can see the title of dialog, but I cannot see the animation composed from dots. My style.xml configuration looks like this one :

<style name="LoadingDialog" parent="android:Theme.DeviceDefault.Dialog">
    <item name="DialogTitleAppearance">@android:style/TextAppearance.Medium</item>
    <item name="DialogTitleText">Loading</item>
    <item name="DialogSpotCount">4</item>
</style>
<color name="spots_dialog_color">@color/nliveo_orange_colorPrimary</color>

Could you give me some additional guidance how fix this issue ? Thanks in advance!

@dybarsky
Copy link
Owner

Hi!
Thank you for your contribution. I will check out this issue and let you know.

@dybarsky
Copy link
Owner

Sorry, can't reproduce at my 4.3 device. It works.
I used your style and created dialog like this:

new SpotsDialog(this, R.style.LoadingDialog).show();

@dybarsky
Copy link
Owner

Do you use proguard ? Can you reproduce this issue on emulator/genymotion?

@GarciaPL
Copy link
Author

Yes I use proguard. Funny thing is that your library works on genymotion, but I have issue on real device.

@GarciaPL
Copy link
Author

I saw somewhere in logs which might be related with issue :

Could not find method android.widget.FrameLayout., referenced from method dmax.dialog.ProgressLayout.. I have debugged app and I suppose that compilation agains Android 23 is too much, because some method is missing.

@dybarsky
Copy link
Owner

Well, first, try to add these lines into you caustom proguard config file to avoid any shrinks:

-keep class dmax.dialog.** {
    *;
}

Next, can you add here whole stack-trace?
I will prepare some build for you, compiled with build tools 22.

@dybarsky
Copy link
Owner

Try to use verison build with build tools 22

compile 'com.github.d-max:spots-dialog:0.6-bt22'

It will be available in 2-3 hours

@dybarsky
Copy link
Owner

dybarsky commented Nov 3, 2015

Hi, Lukasz! How is it going with this problem?

@GarciaPL
Copy link
Author

GarciaPL commented Nov 3, 2015

I was not be able to fix it and unfortunately I used standard android's ProgressDialog. Thanks for help, but it was force majeure. Thanks for your help!

@dybarsky
Copy link
Owner

dybarsky commented Nov 3, 2015

Okay, I see. Tell me please one more thing. Did you try this 6-bt22 version?

@GarciaPL
Copy link
Author

GarciaPL commented Nov 3, 2015

I remember that I was trying but without success.

@dybarsky
Copy link
Owner

dybarsky commented Nov 3, 2015

Okay. Thanks

@jongha
Copy link

jongha commented Dec 4, 2015

I have same issue in 4.4.3 nexus.

edited)
Sorry, After add a proguard (keep class) rule.. work fine. But I don't know why the rule required.

@jongha
Copy link

jongha commented Dec 5, 2015

Finally I found a solution.

Change public class (HesitateInterpolator, AnimatorPlayer, AnimatedView)

or

Keep these three class in proguard rule.

Thanks!

@dybarsky
Copy link
Owner

dybarsky commented Dec 7, 2015

Hi,
thanks for reply. I wrote proguard rules at blogspot article. I think, I need to add the same to readme file here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants