Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue with long texts #26

Closed
FANMixco opened this issue Nov 12, 2017 · 2 comments
Closed

Minor issue with long texts #26

FANMixco opened this issue Nov 12, 2017 · 2 comments

Comments

@FANMixco
Copy link

I think your library is awesome :D! However, there is one minor improvement point:

<TextView
        android:id="@+id/dmax_spots_title"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_marginTop="@dimen/title_margin"
        android:layout_gravity="center"
        android:textAppearance="?attr/DialogTitleAppearance"
        android:text="?attr/DialogTitleText"/>

The layout_width should be match_parent, if it's wrap_content and the text is too long for X or Y reason, it stops working as expected and it goes to the left. Maybe you could update it in your free time! Thanks for so awesome library.

@dybarsky
Copy link
Owner

Hi, @FANMixco! Thanks for feedback and for suggestion. I'll check it out and make new build

@dybarsky
Copy link
Owner

dybarsky commented Jun 5, 2018

Hi. I've checked and layout_width is already match_parent

@dybarsky dybarsky closed this as completed Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants