Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fullscreen mode does not work on Safari browser #706

Open
1 of 3 tasks
Sebasee009 opened this issue Jul 13, 2022 · 1 comment
Open
1 of 3 tasks

Fullscreen mode does not work on Safari browser #706

Sebasee009 opened this issue Jul 13, 2022 · 1 comment
Labels
bug Something isn't working client Improvements or additions to the web client good first issue Good for newcomers ui-ux/user Problem with the UI/UX from an end user perspective

Comments

@Sebasee009
Copy link

Sebasee009 commented Jul 13, 2022 •
edited

Current Behavior

Unfortunately, the Fullscreen mode does not work but with the other browser works

IMG_0152.mov

The video is not from me

Expected Behavior

It should work like with the other browser

Steps To Reproduce

  1. create or join room
  2. Click to toggle full screen

Environment

  • This happens on the official site, opentogethertube.com
  • This happens using a self-hosted version.
  • I'm using the docker image.

Anything else?

none
@Sebasee009 Sebasee009 added bug Something isn't working uncomfirmed Bug has not yet been confirmed, do not start a fix. labels Jul 13, 2022
@dyc3 dyc3 added the client Improvements or additions to the web client label Jul 13, 2022
@dyc3
Copy link
Owner

dyc3 commented Jul 13, 2022 •
edited

Fucking safari... https://caniuse.com/?search=requestFullscreen

It looks like we just need to check for webkitRequestFullscreen if requestFullscreen is not present. This should be an easy PR for a new contributor.

@dyc3 dyc3 added good first issue Good for newcomers and removed uncomfirmed Bug has not yet been confirmed, do not start a fix. labels Jul 13, 2022
@dyc3 dyc3 added the ui-ux/user Problem with the UI/UX from an end user perspective label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working client Improvements or additions to the web client good first issue Good for newcomers ui-ux/user Problem with the UI/UX from an end user perspective
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dyc3 @Sebasee009