Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login via discord / linking discord is offered despite not being configured. #842

Open
2 of 3 tasks
Saladoc opened this issue Mar 18, 2023 · 1 comment
Open
2 of 3 tasks
Labels
bug Something isn't working ui-ux/hoster Problem with the UI/UX from a hoster perspective ui-ux/user Problem with the UI/UX from an end user perspective

Comments

@Saladoc
Copy link

Saladoc commented Mar 18, 2023

Current Behavior

Despite me not configuring the discord application info, the application still offers linking discord accounts and failing with a non-userfriendly error if it is attempted.

Expected Behavior

If discord is not configured, the option to login via it should not be offered, neither should the linking of accounts.

Steps To Reproduce

  1. Start without discord-specific options being configured
  2. Click "link discord" button when logged in
  3. Enjoy a json formatted error message.

Environment

  • This happens on the official site, opentogethertube.com
  • This happens using a self-hosted version.
  • I'm using the docker image.

Anything else?

No response

@Saladoc Saladoc added bug Something isn't working uncomfirmed Bug has not yet been confirmed, do not start a fix. labels Mar 18, 2023
@dyc3 dyc3 added ui-ux/user Problem with the UI/UX from an end user perspective ui-ux/hoster Problem with the UI/UX from a hoster perspective and removed uncomfirmed Bug has not yet been confirmed, do not start a fix. labels Mar 18, 2023
@dyc3
Copy link
Owner

dyc3 commented Mar 18, 2023

Just putting down my thoughts for reference later:

Fixing this is not super straight forward right now. Ideally, we should have a feature flag mechanism so we can turn off rendering for features like this. However, this would require yet another round trip call to the backend on first load with our current infrastructure (we already have 2 and that's bad enough). Maybe we could set up some minimal server-side rendering to set feature flags in a global scope?

Alternatively, we could include the feature flag in a new environment variable at build time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui-ux/hoster Problem with the UI/UX from a hoster perspective ui-ux/user Problem with the UI/UX from an end user perspective
Projects
None yet
Development

No branches or pull requests

2 participants