Skip to content
This repository has been archived by the owner on Feb 20, 2020. It is now read-only.

Update of 2bwn-style-patch #8

Open
Vouivre opened this issue Feb 10, 2020 · 2 comments
Open

Update of 2bwn-style-patch #8

Vouivre opened this issue Feb 10, 2020 · 2 comments

Comments

@Vouivre
Copy link

Vouivre commented Feb 10, 2020

Hello, I wanted to test sowm with the 2bwm-style-patch. I have seen the patch has to be updated. I have tried, but it doesn't work. I have updated the files:

  • config.def.h
  • sowm.h
  • sown.c

I have taken the code from the actual patch and modified accordingly the files above. I get for example:

cp config.def.h config.h
cc -O3 -pipe -march=native -std=c99 -Wall -Wextra -pedantic -Wold-style-declaration -Wmissing-prototypes -Wno-unused-parameter   -c -o sowm.o sowm.c
In file included from sowm.c:11:
sowm.h:57:6: warning: no previous prototype for ‘xerror’ [-Wmissing-prototypes]
   57 | int  xerror() { return 0; }
      |      ^~~~~~
In file included from sowm.c:31:
config.h:32:56: warning: initialization of ‘const char **’ from incompatible pointer type ‘char **’ [-Wincompatible-pointer-types]
   32 |                {MOD,           XK_h,      move,  {.com=(char*[]){"move", "left"}, .i=10}},

Did I do something wrong or do I have to also adapt the code of this patch ?

@fehawen
Copy link

fehawen commented Feb 20, 2020

@Vouivre I had the same problem earlier, but managed to fix it. Will submit a PR with my changes to solve this, although I have no knowledge in C whatsoever, so we'll see if it gets approved or not lol.

@dylanaraps
Copy link
Owner

See: dylanaraps/sowm#57

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants