Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal/Feature Request] Drop constraint in packages which are to be installed from Github #1

Closed
SauravMaheshkar opened this issue Dec 25, 2021 · 0 comments

Comments

@SauravMaheshkar
Copy link

While trying to create a virtual environment I ran into issues multiple times while installing lpips-pytorch and lpips-tensorflow from their specific commit hash. viz.

lpips-pytorch @ git+https://github.com/S-aiueo32/lpips-pytorch.git@d94711e9615d18668bf5a6a9553d4a18493478b5
lpips-tf @ git+git://github.com/alexlee-gk/lpips-tensorflow.git@87bea09959fe030e6fd4af31bc499dfb7e998f93

Removing the commit hash worked just as well for training purposes. i.e.

git+https://github.com/S-aiueo32/lpips-pytorch.git
git+https://github.com/alexlee-gk/lpips-tensorflow.git

Therefore I propose that version constraints be dropped for lpips-pytorch, lpips-tensorflow and RoboNet.


PS: Congratulations to the authors for the paper getting into NeurIPS'21 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant